Add MAX_LEN_UTF8 and MAX_LEN_UTF16 Constants
#120580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTGAzureX1212
changed the title
MAX_LEN_UTF8 and MAX_LEN_UTF16 constantsMAX_LEN_UTF8 and MAX_LEN_UTF16 Constants
Collaborator
|
r? @m-ou-se (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
O-windows
This comment has been minimized.
This comment has been minimized.
m-ou-se
added
T-libs-api
Collaborator
|
☔ The latest upstream changes (presumably #121295) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
In the tracking issue, please include a mention that when stabilizing this we should adjust the documentation of https://doc.rust-lang.org/std/primitive.char.html#method.encode_utf8 to use it. |
Member
|
We briefly discussed this in the libs-api meeting and are happy to add these as unstable. |
m-ou-se
added
S-waiting-on-author
3 tasks
Contributor
Author
|
Tracking issue created. Will finish the remaining things later today. |
HTGAzureX1212
force-pushed
the
HTGAzureX1212/issue-45795
branch
from
177bcc3 to
ae30dc9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
HTGAzureX1212
force-pushed
the
HTGAzureX1212/issue-45795
branch
from
f51dde5 to
bee9b68
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
HTGAzureX1212
force-pushed
the
HTGAzureX1212/issue-45795
branch
from
9c2fb6c to
7786d80
Compare
This comment has been minimized.
This comment has been minimized.
HTGAzureX1212
force-pushed
the
HTGAzureX1212/issue-45795
branch
from
7b97537 to
d797ebe
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Dylan-DPC
added
S-waiting-on-author
GrigorenkoPV
suggested changes
Feb 16, 2025
HTGAzureX1212
force-pushed
the
HTGAzureX1212/issue-45795
branch
from
4ccc716 to
eec49bb
Compare
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
This was referenced Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
MAX_LEN_UTF8andMAX_LEN_UTF16constants as per #45795, gated behind thechar_max_lenfeature.The constants are currently applied in the
alloc,coreandstdlibraries.